On Wed, 20 Nov 2024 14:46:37 +0800 Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote: > From: Yu Kuai <yukuai3@xxxxxxxxxx> > > re-add will not trigger full disk recovery, user should add a new disk > to the array instead. Also update test/05r1-re-add-nosuper to reflect > this. > Description miss information about blocking --re-add for external :) Please add something. I know it is not supported, I just need some note like: "I was never supported for external metadata and behavior is undefined? (please check at least with IMSM), block it" If it fallbacks to standard --add I'm also fine with the change because we are making clear user interface and this will be help to avoid abuses and bug reports. Probably no one is using that with external- I think we can take a risk here. For the code, LGTM. Thanks! Mariusz
