Re: [PATCH 1/2] md/raid5: Increase r5conf.cache_name size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 13, 2024 at 2:18 AM John Garry <john.g.garry@xxxxxxxxxx> wrote:
>
> On 12/11/2024 23:05, Song Liu wrote:
> >>> WDYT?
> >> Indeed it is confusing...
> >> So the string is "raid%d-%s", which is
> >> 4B for "raid"
> >> 10B for max int (right?)
> >> 1B for '-'
> >> 32B for DISK_NAME_LEN
> >> 1B for NUL
> >>
> >> which totals 48
> >>
> >> So I don't know why/how 38 is ok. Maybe there is some auto-padding going
> >> on, like you hint at.
> >>
> >> Maybe just using 48 is better.
> > Makes sense. I will update the patch to use 48, and apply it to md-6.13.
>
> ok, thanks.
>
> And let me know what you think of 2/2, I am even less happy about the
> solution there.

2/2 will go through the device mapper side. Please refer to the following
(from MAINTAINERS).

DEVICE-MAPPER  (LVM)
M:      Alasdair Kergon <agk@xxxxxxxxxx>
M:      Mike Snitzer <snitzer@xxxxxxxxxx>
M:      Mikulas Patocka <mpatocka@xxxxxxxxxx>
L:      dm-devel@xxxxxxxxxxxxxxx
S:      Maintained
Q:      http://patchwork.kernel.org/project/dm-devel/list/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git

Thanks,
Song





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux