On Thu, Nov 7, 2024 at 5:20 AM Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:
>
> 在 2024/11/06 17:51, Xiao Ni 写道:
> > One customer reports a bug: raid5 is hung when changing thread cnt
> > while resync is running. The stripes are all in conf->handle_list
> > and new threads can't handle them.
> >
> > Commit b39f35ebe86d ("md: don't quiesce in mddev_suspend()") removes
> > pers->quiesce from mddev_suspend/resume. Before this patch, mddev_suspend
> > needs to wait for all ios including sync io to finish. Now it's used
> > to only wait normal io.
> >
> > In this patch, it calls raid5_quiesce in raid5_store_group_thread_cnt
> > directly to wait all sync requests to finish before changing the group
> > cnt.
> >
> > Fixes: b39f35ebe86d ("md: don't quiesce in mddev_suspend()")
> > Signed-off-by: Xiao Ni <xni@xxxxxxxxxx>
> > ---
> > drivers/md/raid5.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> LGTM
> Reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx>
Applied to md-6.13. Thanks for the fix!
Song
