Re: [PATCH v2 1/7] block: Use BLK_STS_OK in bio_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/10/2024 16:11, Christoph Hellwig wrote:
On Mon, Oct 28, 2024 at 03:27:24PM +0000, John Garry wrote:
Use the proper blk_status_t value to init the bi_status.
I think 0 as ok is a very wide spread assumption and intentional.

Sure

Personally I think 0 is fine, as it also is special case by
__bitwise types, but if Jens prefers it this way I'm fine with that
too.

I just found it easier to grep BLK_STS_OK (rather than 0). And also proper to init to the declared macro, but I don't feel strongly about this.

Cheers





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux