On 19.09.24 11:25, John Garry wrote: > - BUG_ON(sectors <= 0); > - BUG_ON(sectors >= bio_sectors(bio)); > + if (WARN_ON(sectors <= 0)) > + return ERR_PTR(-EINVAL); > + if (WARN_ON(sectors >= bio_sectors(bio))) > + return ERR_PTR(-EINVAL); Nit: WARN_ON_ONCE() otherwise it'll trigger endless amounts of stacktraces in dmesg.