On Fri 30-08-24 13:01:29, Christian Brauner wrote: > On Fri, Aug 30, 2024 at 11:38:24AM GMT, Michal Hocko wrote: > > On Fri 30-08-24 08:11:00, Hannes Reinecke wrote: > > > On 8/29/24 21:17, Jan Kara wrote: > > > > On Thu 29-08-24 15:06:40, Michal Hocko wrote: > > > > > From: Michal Hocko <mhocko@xxxxxxxx> > > > > > > > > > > There is only one called of alloc_page_buffers and it doesn't require > > > > > __GFP_NOFAIL so drop this allocation mode. > > > > > > > > > > Signed-off-by: Michal Hocko <mhocko@xxxxxxxx> > > > > > > > > Looks good. Feel free to add: > > > > > > > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > > > > > > > Although even better fix would be to convert the last remaining caller of > > > > alloc_page_buffers() to folio_alloc_buffers()... But that may be more > > > > difficult. > > > > > > > Already done by Pankajs large-block patchset, currently staged in vfs.git. > > > > Which branch should I be looking at? > > Hi Michal, Hannes should be referring to: > https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/log/?h=vfs.blocksize OK, but that branch seems to still have alloc_page_buffers user. Maybe I am just misunderstanding what am I supposed to do here. Anyway, I won't have much time to spend refactoring this so if there are more changes required then I will likely not get to that. Sorry. -- Michal Hocko SUSE Labs
