On 6/14/24 10:03 AM, Christoph Hellwig wrote: > On Fri, Jun 14, 2024 at 06:33:41AM -0600, Jens Axboe wrote: >>> The series is based on top of my previously sent "convert the SCSI ULDs >>> to the atomic queue limits API v2" API. >> >> I was going to queue this up, but: >> >> drivers/scsi/sd.c: In function ?sd_revalidate_disk?: >> drivers/scsi/sd.c:3658:45: error: ?lim? undeclared (first use in this function) >> 3658 | sd_config_protection(sdkp, &lim); >> | ^~~ >> drivers/scsi/sd.c:3658:45: note: each undeclared identifier is reported only once for each function it appears in > > That sounds like you didn't apply the above mentioned > "convert the SCSI ULDs to the atomic queue limits API v2" series before? That might indeed explain it... Surprising it applied without. -- Jens Axboe