Re: [PATCH 13/26] block: move cache control settings out of queue->flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Damien Le Moal <dlemoal@xxxxxxxxxx>
Subject: Re: [PATCH 13/26] block: move cache control settings out of queue->flags
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 12 Jun 2024 06:54:29 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yu Kuai <yukuai3@xxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <d21b162a-1fd3-4fd1-a17f-f127f964bdf1@kernel.org>
References: <20240611051929.513387-1-hch@lst.de> <20240611051929.513387-14-hch@lst.de> <d21b162a-1fd3-4fd1-a17f-f127f964bdf1@kernel.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Jun 11, 2024 at 04:55:04PM +0900, Damien Le Moal wrote:
> On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> > Move the cache control settings into the queue_limits so that they
> > can be set atomically and all I/O is frozen when changing the
> > flags.
> 
> ...so that they can be set atomically with the device queue frozen when
> changing the flags.
> 
> may be better.

Sure.

If there was anything below I've skipped it after skipping over two
pages of full quotes.

References:
- move features flags into queue_limits
  - From: Christoph Hellwig
- [PATCH 13/26] block: move cache control settings out of queue->flags
  - From: Christoph Hellwig
- Re: [PATCH 13/26] block: move cache control settings out of queue->flags
  - From: Damien Le Moal

Prev by Date: Re: [PATCH 13/26] block: move cache control settings out of queue->flags
Next by Date: Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits
Previous by thread: Re: [PATCH 13/26] block: move cache control settings out of queue->flags
Next by thread: Re: [PATCH 13/26] block: move cache control settings out of queue->flags
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]