On Sat, Jun 08, 2024 at 12:01:43AM +0530, Kanchan Joshi wrote:
> > + if (!bi || bi->csum_type != BLK_INTEGRITY_CSUM_NONE) {
> > ti->error = "Integrity profile not supported.";
> > return -EINVAL;
>
> I'd rename BLK_INTEGRITY_CSUM_NONE to BLK_INTEGRITY_CSUM_NOP. Overall.
Well, we don't do any checksumming here, and not a no-op checksum.
So in terms of the checksum field I think the name is correct. But
it is indeed confusing vs the format string, but that is an ABI
we can't change..
