Re: [PATCH 07/12] block: use kstrtoul in flag_store

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 07/12] block: use kstrtoul in flag_store
From: Keith Busch <kbusch@xxxxxxxxxx>
Date: Wed, 5 Jun 2024 10:00:56 -0600
Cc: Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yu Kuai <yukuai3@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx
In-reply-to: <20240605063031.3286655-8-hch@lst.de>
References: <20240605063031.3286655-1-hch@lst.de> <20240605063031.3286655-8-hch@lst.de>

On Wed, Jun 05, 2024 at 08:28:36AM +0200, Christoph Hellwig wrote:
> Use the text to integer helper that has error handling and doesn't modify
> the input pointer.

Looks good. 

Reviewed-by: Keith Busch <kbusch@xxxxxxxxxx>

References:
- move integrity settings to queue_limits
  - From: Christoph Hellwig
- [PATCH 07/12] block: use kstrtoul in flag_store
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 06/12] block: factor out flag_{store,show} helper for integrity
Next by Date: Re: [PATCH 02/12] block: remove the unused BIP_{CTRL,DISK}_NOCHECK flags
Previous by thread: [PATCH 07/12] block: use kstrtoul in flag_store
Next by thread: Re: [PATCH 07/12] block: use kstrtoul in flag_store
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]