On Tue, 28 May 2024 21:51:46 +0800 Xiao Ni <xni@xxxxxxxxxx> wrote: > Hi all > > This is the third patch set that fix and enhance some test cases. Applied all. Here some minor comments: > > Xiao Ni (4): > mdadm/tests: bitmap cases enhance > mdadm/tests: 04update-uuid you can remove testing of bitmap file. > mdadm/tests: 05r1-re-add-nosuper same in this test. I missed those tests but I wrote in 50b100768a11: "The implementation of custom bitmap file looks like it's abandoned. It cannot be done by Incremental so it is not respected by any udev based system and it seems to not be recorded by metadata. User must assemble such volume manually." I do not consider it as a real-life feature. We should help it to become deprecated (it is in kernel) and dropping tests is reasonable for me. Thanks for patches, Mariusz