Hello Song Liu,
Commit d8730f0cf4ef ("md: Remove deprecated CONFIG_MD_MULTIPATH")
from Dec 14, 2023 (linux-next), leads to the following Smatch static
checker warning:
drivers/md/md.c:3862 analyze_sbs()
warn: iterator 'i' not incremented
drivers/md/md.c
3861
--> 3862 i = 0;
3863 rdev_for_each_safe(rdev, tmp, mddev) {
3864 if (mddev->max_disks &&
3865 (rdev->desc_nr >= mddev->max_disks ||
3866 i > mddev->max_disks)) {
^
There used to be an i++ but that patch deleted it. Should i just be
deleted?
3867 pr_warn("md: %s: %pg: only %d devices permitted\n",
3868 mdname(mddev), rdev->bdev,
3869 mddev->max_disks);
3870 md_kick_rdev_from_array(rdev);
3871 continue;
3872 }
3873 if (rdev != freshest) {
3874 if (super_types[mddev->major_version].
3875 validate_super(mddev, freshest, rdev)) {
3876 pr_warn("md: kicking non-fresh %pg from array!\n",
3877 rdev->bdev);
3878 md_kick_rdev_from_array(rdev);
3879 continue;
3880 }
3881 }
3882 if (rdev->raid_disk >= (mddev->raid_disks - min(0, mddev->delta_disks)) &&
3883 !test_bit(Journal, &rdev->flags)) {
3884 rdev->raid_disk = -1;
3885 clear_bit(In_sync, &rdev->flags);
3886 }
3887 }
3888
3889 return 0;
3890 }
regards,
dan carpenter
