Re: [PATCH 0/1] Move mdadm development to Github

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Mariusz,


Thank for bringing this topic up for discussion. Unfortunately, I have to reply with negative comments.


Am 19.04.24 um 03:48 schrieb Mariusz Tkaczyk:
Thanks to Song and Paul, we created organization for md-raid on Github.
This is a perfect place to maintain mdadm. I would like announce moving
mdadm development to Github.

It is already forked, feel free to explore:
https://github.com/md-raid-utilities/mdadm

Github is powerful and it has well integrated CI. On the repo, you can
already find a pull request which will add compilation and code style
tests (Thanks to Kinga!).
This is MORE than we have now so I believe that with the change mdadm
stability and code quality will be increased. The participating method
will be simplified, it is really easy to create pull request. Also,
anyone can fork repo with base tests included and properly configured.

Note that Song and Paul are working on a per patch CI system using GitHub
Actions and a dedicated rack of servers to enable fast container, VM and
bare metal testing for both mdraid and mdadm. Having mdadm on GitHub will
help with that integration.

Improved testing sounds good. Thank you. I do not think though, that using GitHub is a requirement for that, and there are a lot of bots on the Linux kernel mailing list doing this without GitHub.

As a result of moving to GitHub, we will no longer be using mailing list
to propose patches, we will be using GitHub Pull Requests (PRs). As the
community adjusts to using PRs I will be setting up auto-notification
for those who attempt to use email for patches to let them know that we
now use PRs.  I will also setup GitHub to send email to the mailing list
on each new PR so that everyone is still aware of pending patches via
the mailing list.

In my experience, using GitHub for code review is far inferior to using mailing lists or Gerrit. First, you cannot comment on the commit message. As a result, projects using GitHub have a really low-quality git history. Also, you only cannot comment single parts of a line in the diff.

The “one thread” discussion model is also a pain, as most people using Web forms do not correctly cite and quote, and with more than three answers you loose the overview. For some reason people think more about their reply, using mailing lists than Web forms.

Using different forums for discussions should also not be allowed. People should just subscribe and monitor one forum.

So, I strongly oppose this move, but I am also aware, that I am not doing a lot of development contribution.


Kind regards,

Paul




[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux