Hi Jens, > On Apr 25, 2024, at 1:02 PM, Jens Axboe <axboe@xxxxxxxxx> wrote: > > On 4/25/24 1:51 PM, Song Liu wrote: >> Hi Jens, >> >> Please consider pulling the following changes for md-6.10 on top of your >> for-6.10/block branch. These changes contain various fixes by Yu Kuai, >> Li Nan, and Florian-Ewald Mueller. >> >> Please note that change "md: Fix overflow in is_mddev_idle" changes >> gendisk->sync_io from blkdev.h. This is only used by md, so I included >> this change in this pull request. > > A bit dubious to just bump the counts to 64-bit, I think. You only care > about the difference, so regular integer math should suffice. In fact > you only care about the difference. Feels like a bit of a lazy fix to be > honest. > > I've pulled this, but I would strongly suggest to re-visit this change > and spend a bit more time getting this right, rather than just blindly > bumping everything to a 64-bit value. I don't care about the md bits > here, just the gendisk side. Thanks for the advice! We will look more into this and come up with a follow-up or update. Song
