Re: [PATCH 1/5] tests/test enhance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 19, 2024 at 3:30 PM Mateusz Kusiak
<mateusz.kusiak@xxxxxxxxxxxxxxx> wrote:
>
> On 19.04.2024 09:16, Mateusz Kusiak wrote:
> > Hi Xiao,
> > one small note from me.
> >
> > On 18.04.2024 12:23, Xiao Ni wrote:
> >> @@ -309,6 +322,7 @@ print_warning() {
> >>   main() {
> >>       print_warning
> >>       do_setup
> >> +    record_system_speed_limit
> >>       echo "Testing on linux-$(uname -r) kernel"
> >>       [ "$savelogs" == "1" ] &&
> >
> >
> > I feel like record_system_speed_limit() should be called in do_setup() rather than main().
> > Saving current system settings is job of setup.

Thanks for the suggestion.

> >
> > Thanks,
> > Mateusz
> >
>
> One more thing. Feel free to add tag "fixes".
> I broke this behavior (lowering sync speed) in 4c12714d1ca0 ("test: run tests on system level mdadm").

Ok, no problem.

Regards
Xiao
>
> Thanks,
> Mateusz
>






[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux