Re: [PATCH 5/5] tests/01raid6integ.broken can be removed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 19, 2024 at 3:06 AM Mariusz Tkaczyk
<mariusz.tkaczyk@xxxxxxxxxxxxxxx> wrote:
>
> On Thu, 18 Apr 2024 18:23:21 +0800
> Xiao Ni <xni@xxxxxxxxxx> wrote:
>
> > 01raid6integ can be run successfully with kernel 6.9.0-rc3.
> > So remove 01raid6integ.broken.
> >
> > Signed-off-by: Xiao Ni <xni@xxxxxxxxxx>
> > ---
> I don't follow the *.broken file concept. We could also describe that in comment
> in the test, so LGTM for the changes.
>
> If you want to, you can remove all *.broken files and add some comments
> in test instead. If we have some tests failing marked as broken long time ago,
> you can either remove those scenarios as we are obiously not interested in
> fixing those scenarios.

test script has options to skip broken tests (--skip-broken,
--skip-always-broken).
If we remove all the .broken files, we need to update the script to handle
comments in the test file.

Thanks,
Song





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux