Hi Paul, Thanks for reviewing the patch! On Wed, Mar 6, 2024 at 7:10 AM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote: > > Dear Kuai, > > > Am 05.03.24 um 09:13 schrieb Yu Kuai: > > > 在 2024/03/05 16:08, Paul Menzel 写道: > > >> Am 05.03.24 um 08:22 schrieb Yu Kuai: > >>> From: Yu Kuai <yukuai3@xxxxxxxxxx> > >>> > >>> The new heleprs will be used in dm-raid in later patches to fix > >> > >> hel*pe*rs > >> > >>> regressions and prevent calling md_reap_sync_thread() directly. > >> > >> Please list the new functions. > >> > >> 1. md_idle_sync_thread(struct mddev *mddev); > >> 2. md_frozen_sync_thread(struct mddev *mddev); > >> 3. md_unfrozen_sync_thread(struct mddev *mddev); > >> > >> I do not like the naming so much. `md_reap_sync_thread()` has the verb > >> in imperative mood. At least myself, I would not know what the > >> functions do exactly without looking at the implementation. > > > > Thanks for the suggestions, I'm not that good at naming :( > > > > Usually I'll send a new version with updated naming, however, we must > > merge this set ASAP now, perhaps can we live with this for now? > > Fine by me. Maybe when applying the typo can be fixed, and the naming > than later. Yes, I did exactly this when applying the patches, but forgot to mention it here. Song
