Dear Paul, dear Kuai
Am 22.02.24 um 14:04 schrieb Luse, Paul E:
On Feb 22, 2024, at 2:08 AM, Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:
在 2024/02/22 16:40, Paul Menzel 写道:
Is there a change in performance with the current patch set? Is
radi1 well enough covered by the test suite?
Yes, there are no performance degradation, and mdadm tests passed.
And Paul Luse also ran fio mixed workload w/data integrity and it
passes.
Kuai is correct, in my original perf improvement patch I included
lots of results. For this set where we just refactored I checked
performance to assure we didn't go downhill but didn't save the
results as deltas were in the noise. After this series lands we will
look at introducing performance improvements again and at that time
results from a full performance sweep will be included.
For data integrity, 1 and 2 disk mirrors were ran overnight w/fio and
crcr32 check - no issues.
To assure other code paths execute as they did before was a little
trickier without a unit test framework but for those cases I did
modify/un-modify the code several times to follow various code paths
and assure they're working as expected (ie bad blocks, etc)
Thank you very much for the elaborate response.
In our infrastructure, we often notice things improve, but we sometimes
also have the “feeling” that things get worse. As IO is so complex, I
find it always helpful to exactly note down the test setup and the run
tests. So thank you for responding.
Kind regards,
Paul
