Re: [PATCH -next v2 2/2] md/raid5-cache: fix null-ptr-deref in r5l_reclaim_thread()

[Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>]

Hi,

在 2023/07/07 17:36, Song Liu 写道:
> On Fri, Jul 7, 2023 at 5:19 PM Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:
> > Hi,
> >
> > 在 2023/07/07 17:16, Yu Kuai 写道:
> > > Perhaps you means this order?
> > >
> > > r5l_exit_log
> > >    flush_work(&log->disable_writeback_work)
> > >    conf->log = NULL
> > >    md_unregister_thread(&log->reclaim_thread)
> > >
> > > I think this is better indeed.
> > Never mind, this is wrong, I got confused...
> >
> > Please ignore this and take a look at my original fix.
>
> How about
>
> r5l_exit_log
>    md_unregister_thread(&log->reclaim_thread)
>    conf->log = NULL
>    flush_work(&log->disable_writeback_work)
>
> ?

This looks correct, expect that wake_up() should be moved together.

I'll send a v2.

Thanks,
Kuai
> Thanks,
> Song
> .