Re: [PATCH -next 2/3] md/dm-raid: cleanup multiple equivalent goto tags from raid_ctr()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

在 2023/07/06 21:01, Paul Menzel 写道:
Dear Yu,


Thank you for your patch. Some minor nits, if you are interested.

Am 06.07.23 um 09:16 schrieb Yu Kuai:
From: Yu Kuai <yukuai3@xxxxxxxxxx>

There are four equivalent goto tags in raid_ctr(), clean them up to use
just one, there are no functional change and prepare to fix that

Maybe:

There *is* no functional change, and is a preparation to fix an unprotected `md_stop()`.

md_stop() is not protected.

In the commit message summary/title, I’d spell the verb with a space:

     Clean up four equivalent goto tags in raid_ctr()


Thanks for the suggestions, I'll update them in the next version.

Thanks,
Kuai
Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
---
  drivers/md/dm-raid.c | 27 +++++++++------------------
  1 file changed, 9 insertions(+), 18 deletions(-)

[…]


Kind regards,

Paul

.





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux