Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails
From: Song Liu <song@xxxxxxxxxx>
Date: Tue, 30 May 2023 21:58:19 -0700
Cc: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Bob Peterson <rpeterso@xxxxxxxxxx>, Andreas Gruenbacher <agruenba@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, gouhao@xxxxxxxxxxxxx, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
In-reply-to: <20230531042502.GM32705@lst.de>
References: <cover.1685461490.git.johannes.thumshirn@wdc.com> <c60c6f46b70c96b528b6c4746918ea87c2a01473.1685461490.git.johannes.thumshirn@wdc.com> <20230531042502.GM32705@lst.de>

On Tue, May 30, 2023 at 9:25 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> To me these look like __bio_add_page candidates, but I guess Song
> preferred it this way?  It'll add a bit pointless boilerplate code,
> but I'm ok with that.

We had some discussion on this in v2, and decided to keep these
assert-like WARN_ON().

Thanks,
Song

Follow-Ups:
- Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails
  - From: Paul Menzel

References:
- [PATCH v6 00/20] bio: check return values of bio_add_page
  - From: Johannes Thumshirn
- [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails
  - From: Johannes Thumshirn
- Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH v6 20/20] block: mark bio_add_folio as __must_check
Next by Date: Re: [PATCH -next v3 3/7] md/raid1-10: factor out a helper to submit normal write
Previous by thread: Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails
Next by thread: Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]