Re: [PATCH v6 17/20] block: mark bio_add_page as __must_check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
Subject: Re: [PATCH v6 17/20] block: mark bio_add_page as __must_check
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 31 May 2023 06:25:49 +0200
Cc: Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, Song Liu <song@xxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Bob Peterson <rpeterso@xxxxxxxxxx>, Andreas Gruenbacher <agruenba@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, gouhao@xxxxxxxxxxxxx, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
In-reply-to: <7b1df30b0db4cd34a3c9d66c9c126dccaf2eb52f.1685461490.git.johannes.thumshirn@wdc.com>
References: <cover.1685461490.git.johannes.thumshirn@wdc.com> <7b1df30b0db4cd34a3c9d66c9c126dccaf2eb52f.1685461490.git.johannes.thumshirn@wdc.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> +int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off);

Please spell out all parameters while you touch this, and also avoid the
overly long line.

References:
- [PATCH v6 00/20] bio: check return values of bio_add_page
  - From: Johannes Thumshirn
- [PATCH v6 17/20] block: mark bio_add_page as __must_check
  - From: Johannes Thumshirn

Prev by Date: Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails
Next by Date: Re: [PATCH v6 18/20] block: add __bio_add_folio
Previous by thread: [PATCH v6 17/20] block: mark bio_add_page as __must_check
Next by thread: [PATCH v6 18/20] block: add __bio_add_folio
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]