On Sun, May 28, 2023 at 12:49 AM Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote: > > 在 2023/05/27 18:18, linan666@xxxxxxxxxxxxxxx 写道: > > From: Li Nan <linan122@xxxxxxxxxx> > > > > Commit 1a855a060665 ("md: fix bug with re-adding of partially recovered > > device.") only add device which is set to In_sync. But it let devices > > without metadata cannot be added when they should be. > > > > Commit bf572541ab44 ("md: fix regression with re-adding devices to arrays > > with no metadata") fix the above issue, it set device without metadata to > > In_sync when add new disk. > > > > However, after commit f466722ca614 ("md: Change handling of save_raid_disk > > and metadata update during recovery.") deletes changes of the first patch, > > setting In_sync for devcie without metadata is meanless because the flag > > will be cleared soon and will not be used during this period. Clean it up. > > LGME, feel free to add: > > Reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx> > > > > Signed-off-by: Li Nan <linan122@xxxxxxxxxx> Applied to md-next. Thanks, Song