Hi,
在 2023/03/26 20:56, Tom Rix 写道:
clang with W=1 reports
drivers/md/raid5.c:7719:6: error: variable 'working_disks'
set but not used [-Werror,-Wunused-but-set-variable]
int working_disks = 0;
^
This variable is not used so remove it.
Other than some nits below, this patch looks good to me, feel free to
add:
Reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx>
Please also mention that commit 908f4fbd2657 ("md/raid5: be more
thorough in calculating 'degraded' value.") remove the last reference.
Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
---
drivers/md/raid5.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 7b820b81d8c2..2b1e78c46817 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7716,7 +7716,6 @@ static void raid5_set_io_opt(struct r5conf *conf)
static int raid5_run(struct mddev *mddev)
{
struct r5conf *conf;
- int working_disks = 0;
int dirty_parity_disks = 0;
struct md_rdev *rdev;
struct md_rdev *journal_dev = NULL;
@@ -7913,7 +7912,6 @@ static int raid5_run(struct mddev *mddev)
goto abort;
}
if (test_bit(In_sync, &rdev->flags)) {
- working_disks++;
Please remove the braces as well,
Thanks,
Kuai
continue;
}
/* This disc is not fully in-sync. However if it
