when we excute mdadm --assemble, udev-md-raid-assembly.rules is triggered.
Then we stop array, we found an coredump for mdadm --incremental.func
stack are as follows:
#0 enough (level=10, raid_disks=4, layout=258, clean=1,
avail=avail@entry=0x0) at util.c:555
#1 0x0000562170c26965 in Incremental (devlist=<optimized out>,
c=<optimized out>, st=0x5621729b6dc0) at Incremental.c:514
#2 0x0000562170bfb6ff in main (argc=<optimized out>,
argv=<optimized out>) at mdadm.c:1762
func enough() use array avail,avail allocate space in func count_active,
it may not alloc space, causing a coredump.We fix this coredump.
Signed-off-by: miaoguanqin <miaoguanqin@xxxxxxxxxx>
Signed-off-by: lixiaokeng <lixiaokeng@xxxxxxxxxx>
---
Incremental.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Incremental.c b/Incremental.c
index a4ff7d4..acbbee7 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -506,6 +506,9 @@ int Incremental(struct mddev_dev *devlist, struct context *c,
GET_OFFSET | GET_SIZE));
active_disks = count_active(st, sra, mdfd, &avail, &info);
+ if (!avail)
+ goto out_unlock;
+
journal_device_missing = (info.journal_device_required) && (info.journal_clean == 0);
if (info.consistency_policy == CONSISTENCY_POLICY_PPL)
@@ -620,7 +623,8 @@ int Incremental(struct mddev_dev *devlist, struct context *c,
rv = 0;
}
out:
- free(avail);
+ if (avail)
+ free(avail);
if (dfd >= 0)
close(dfd);
if (mdfd >= 0)
--
2.33.0
