Re: [song-md:md-next 15/18] drivers/md/md-cluster.c:425:42: error: use of undeclared identifier 'mddev'; did you mean 'mode'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Song

在 2023/03/14 17:13, kernel test robot 写道:
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
head:   ec7246c9455e83f452055cec9c39bd54e72217a4
commit: 48b34bba06372e5f6645716b57394db28fa7260c [15/18] md: refactor md_wakeup_thread()
config: s390-randconfig-r032-20230312 (https://download.01.org/0day-ci/archive/20230314/202303141758.4EtLtIA1-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         # install s390 cross compiling tool for clang build
         # apt-get install binutils-s390x-linux-gnu
         # https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git/commit/?id=48b34bba06372e5f6645716b57394db28fa7260c
         git remote add song-md git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git
         git fetch --no-tags song-md md-next
         git checkout 48b34bba06372e5f6645716b57394db28fa7260c
         # save the config file
         mkdir build_dir && cp config build_dir/.config
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 olddefconfig
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/md/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202303141758.4EtLtIA1-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/md/md-cluster.c:425:42: error: use of undeclared identifier 'mddev'; did you mean 'mode'?
                            md_wakeup_thread(&cinfo->recv_thread, mddev);
                                                                  ^~~~~
                                                                  mode
    drivers/md/md-cluster.c:418:37: note: 'mode' declared here
    static void ack_bast(void *arg, int mode)
                                        ^
    1 error generated.


vim +425 drivers/md/md-cluster.c

    412	
    413	/*
    414	 * The BAST function for the ack lock resource
    415	 * This function wakes up the receive thread in
    416	 * order to receive and process the message.
    417	 */
    418	static void ack_bast(void *arg, int mode)
    419	{
    420		struct dlm_lock_resource *res = arg;
    421		struct md_cluster_info *cinfo = res->mddev->cluster_info;
    422	
    423		if (mode == DLM_LOCK_EX) {
    424			if (test_bit(MD_CLUSTER_ALREADY_IN_CLUSTER, &cinfo->state))
  > 425				md_wakeup_thread(&cinfo->recv_thread, mddev);

Sorry that I didn't open md-cluster config, and I failed to test this in
my environment.

Sincerely sorry for the trouble, I'll send new version and make sure all
model is tested.

Thanks,
Kuai

    426			else
    427				set_bit(MD_CLUSTER_PENDING_RECV_EVENT, &cinfo->state);
    428		}
    429	}
    430	




[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux