On Mon, 13 Mar 2023 10:22:47 -0400 Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx> wrote: > On 12/21/22 06:50, Mariusz Tkaczyk wrote: > > When the user creates a device with a name that contains whitespace, > > mdadm timeouts and throws an error. This issue is caused by udev, which > > truncates /dev/md link until the first whitespace. > > > > This patch introduces prohibition of characters other than A-Za-z0-9.-_ > > in the device name. Also, it prohibits using leading "-" in device name, > > so name won't be confused with cli parameter. > > Set of allowed characters is taken from POSIX 3.280 Portable Character > > Set. Also, device name length now is limited to NAME_MAX. > > > > In some places there are other requirements for string length (e.g. size > > up to MD_NAME_MAX for device name). This routine is made to follow POSIX > > and other, more strict limitations should be checked separately. > > We are aware of the risk of regression in exceptional cases (as > > escape_devname function is removed) that should be fixed by updating > > the array name. > > > > The posix validation is added for: > > - 'name' parameter in every mode. > > - secondary device name (first devlist entry), only for create and > > assembly. > > > > To limit regression risk, config entries are excluded from POSIX > > validation. > > > > Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@xxxxxxxxxxxxxxx> > > Hi Mariusz, > > This no longer applies cleanly. Any chance you can post an updated version? > Hi Jes, Working on next version. I think that I omitted one place, need to dig into again. I should make a test for that too. Thanks, Mariusz
