On 2/23/23 18:50, Heming Zhao wrote:
> Hello Jes,
>
> On 2/24/23 2:23 AM, Jes Sorensen wrote:
>> On 2/23/23 09:39, Heming Zhao wrote:
>>> Commit a042210648ed ("disallow create or grow clustered bitmap with
>>> writemostly set") introduced this bug. We should use 'true' logic not
>>> '== 0' to deny setting up clustered array under WRITEMOSTLY condition.
>>>
>>> How to trigger
>>>
>>> ```
>>> ~/mdadm # ./mdadm -Ss && ./mdadm --zero-superblock /dev/sd{a,b}
>>> ~/mdadm # ./mdadm -C /dev/md0 -l mirror -b clustered -e 1.2 -n 2 \
>>> /dev/sda /dev/sdb --assume-clean
>>> mdadm: array /dev/md0 started.
>>> ~/mdadm # ./mdadm --grow /dev/md0 --bitmap=none
>>> ~/mdadm # ./mdadm --grow /dev/md0 --bitmap=clustered
>>> mdadm: /dev/md0 disks marked write-mostly are not supported with
>>> clustered bitmap
>>> ```
>>>
>>> Signed-off-by: Heming Zhao <heming.zhao@xxxxxxxx>
>>
>> Applied!
>>
>> Thanks,
>> Jes
>>
>
> With Paul Menzel comment, I will remove the dot/period in patch subject
> then
> send a v2.
I already applied it. I don't think the dot is worth respinning the
patch for.
Thanks,
Jes
