Hi Nigel, Ping? Thanks, Mariusz On Thu, 17 Nov 2022 15:07:41 +0100 Mariusz Tkaczyk <mariusz.tkaczyk@xxxxxxxxxxxxxxx> wrote: > On Thu, 29 Sep 2022 11:35:21 +0200 > Kinga Tanska <kinga.tanska@xxxxxxxxxxxxxxx> wrote: > > > On Fri, 23 Sep 2022 10:26:35 -0400 > > Nigel Croxon <ncroxon@xxxxxxxxxx> wrote: > > > > > After creating a raid array on top of a imsm container. Try to > > > grow the chunk size and the reshape will hang with zero progress. > > > The reason is the computation of sync_max_to_set value: > > > > Hi Nigel, > > > > I was trying to retest with your patch but still have the defect. I > > analyzed it and found another reason, which causes this defect. In > > validate_geometry_imsm function freesize and super is being checked and > > return 1 if any of those is NULL. In my opinion 0 shall be returned > > here, because it is an error and reshape should be stopped here. I will > > prepare proper patch and send to review immediately. > > > Hi Nigel, > I agree with Kinga. > https://patchwork.kernel.org/project/linux-raid/patch/20221028025117.27048-1-kinga.tanska@xxxxxxxxx/ > Could you please retest the proposed patch on your side and provide feedback? > > Thanks, > Mariusz
