On Sat, Jan 21, 2023 at 1:18 AM Song Liu <song@xxxxxxxxxx> wrote: > > On Wed, Jan 18, 2023 at 1:30 AM Xiao Ni <xni@xxxxxxxxxx> wrote: > > > > Hi all > > > > There are two main changes in the patch set. > > > > The first is to change ->active_io to percpu(patch02). The second > > one is adding a counter for io_acct(patch03). > > > > Hi Xiao, > > If I understand correctly, > > > Xiao Ni (4): > > Factor out is_md_suspended helper > > Change active_io to percpu > > Patch 1 and 2 are performance optimization? Hi Song Yes. These two patches are optimized for performance. At first, I thought to use the active_io to fix the raid0 bug. But we can't move acitve_io out from md_handle_request. So I used a new counter to monitor the bios that raid0 submits to member disks. > > > Add mddev->io_acct_cnt for raid0_quiesce > > Free writes_pending in md_stop > > And patch 3 and 4 fixes two issues? > > It is probably better to send them as 3 separate patches (sets). Yes, they fix two bugs. I'll divide them into 3 patch sets. > > Also, please provide more information on why we need these > changes. Sure, I've written the reason in the specific patch. Best Regards Xiao > > Thanks, > Song > > > > > drivers/md/md.c | 69 ++++++++++++++++++++++++++++++++++------------ > > drivers/md/md.h | 11 +++++--- > > drivers/md/raid0.c | 6 ++++ > > 3 files changed, 65 insertions(+), 21 deletions(-) > > > > -- > > 2.32.0 (Apple Git-132) > > >
