On Tue, Nov 1, 2022 at 4:44 PM Xiao Ni <xni@xxxxxxxxxx> wrote: > > On Wed, Nov 2, 2022 at 4:21 AM Song Liu <song@xxxxxxxxxx> wrote: > > > > On Mon, Oct 31, 2022 at 10:08 PM Xiao Ni <xni@xxxxxxxxxx> wrote: > > > > Please update the subject as md/raid0, raid10: xxx. > > Sorry for forgetting about this again. > > > > > > > > > It should use disk_stack_limits to get a proper max_discard_sectors > > > rather than setting a value by stack drivers. > > > > > > And there is a bug. If all member disks are rotational devices, > > > raid0/raid10 set max_discard_sectors. So the member devices are > > > not ssd/nvme, but raid0/raid10 export the wrong value. It reports > > > warning messages in function __blkdev_issue_discard when mkfs.xfs > > > > Please provide more information about this bug: the warning message, > > the impact, etc. in the commit log. > > I remember we need to obey a rule to paste the warning/panic messages, > right? If so, can you tell the position again? I use the keyword > "warning/panic/calltrace" > to search in file process/submitting-patches.rst and can't find the > useful information. > Or it just needs to paste the calltraces in the patch? I think we can just paste the call trace in the commit log. Thanks, Song