Re: [PATCH v3 4/5] md/raid10: fix improper BUG_ON() in raise_barrier()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>, song@xxxxxxxxxx, guoqing.jiang@xxxxxxxxx, pmenzel@xxxxxxxxxxxxx
Subject: Re: [PATCH v3 4/5] md/raid10: fix improper BUG_ON() in raise_barrier()
From: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Date: Fri, 16 Sep 2022 12:36:26 -0600
Cc: linux-raid@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, yukuai3@xxxxxxxxxx, yi.zhang@xxxxxxxxxx
In-reply-to: <20220916113428.774061-5-yukuai1@huaweicloud.com>
References: <20220916113428.774061-1-yukuai1@huaweicloud.com> <20220916113428.774061-5-yukuai1@huaweicloud.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0


On 2022-09-16 05:34, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
> 
> 'conf->barrier' is protected by 'conf->resync_lock', reading
> 'conf->barrier' without holding the lock is wrong.
> 
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>

Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>

References:
- [PATCH v3 0/5] md/raid10: reduce lock contention for io
  - From: Yu Kuai
- [PATCH v3 4/5] md/raid10: fix improper BUG_ON() in raise_barrier()
  - From: Yu Kuai

Prev by Date: Re: [PATCH v3 3/5] md/raid10: prevent unnecessary calls to wake_up() in fast path
Next by Date: Re: [PATCH v3 5/5] md/raid10: convert resync_lock to use seqlock
Previous by thread: [PATCH v3 4/5] md/raid10: fix improper BUG_ON() in raise_barrier()
Next by thread: Re: [PATCH v3 4/5] md/raid10: fix improper BUG_ON() in raise_barrier()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]

Powered by Linux