On 2022-09-12 11:40, Martin K. Petersen wrote: >> Because write-zero requests may be slow and most (but not all) discard >> requests read back as zeros, this work uses only discard requests. > > REQ_OP_WRITE_ZEROES will pick the most optimal way to guarantee that all > blocks in the requested range will return zeroes for subsequent reads. Makes sense to me. I wanted to use WRITE_ZEROS but was disappointed in the performance even on the nvme drive we tested. I'll respin this to use WRITE_ZEROS and maybe we can do some investigation on more NVMe drives to see if more of them might do it efficiently. Thanks, Logan