Re: [PATCH 08/10] Change update to enum in update_super and update_subarray

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> 2022年8月18日 22:56,Mateusz Kusiak <mateusz.kusiak@xxxxxxxxx> 写道:
> 
> Use already existing enum, change update_super and update_subarray
> update to enum globally.
> Refactor function references also.
> Remove code specific options from update_options.
> 
> Signed-off-by: Mateusz Kusiak <mateusz.kusiak@xxxxxxxxx>
> ---
> Assemble.c    | 14 +++++++++-----
> Examine.c     |  2 +-
> Grow.c        |  9 +++++----
> Manage.c      | 14 ++++++++------
> maps.c        | 21 ---------------------
> mdadm.h       | 12 +++++++++---
> super-intel.c | 16 ++++++++--------
> super0.c      |  9 ++++-----
> super1.c      | 17 ++++++++---------
> 9 files changed, 52 insertions(+), 62 deletions(-)
> 
> diff --git a/Assemble.c b/Assemble.c
> index 6df6bfbc..8cd3d533 100644
> --- a/Assemble.c
> +++ b/Assemble.c
> 

> @@ -1813,7 +1817,7 @@ try_again:
> 	    !enough(content->array.level, content->array.raid_disks,
> 		    content->array.layout, clean,
> 		    avail)) {
> -		change += st->ss->update_super(st, content, "force-array",
> +		change += st->ss->update_super(st, content, UOPT_SPEC_FORCE_ARRAY,
> 					       devices[chosen_drive].devname, c->verbose,
> 					       0, NULL);
> 		was_forced = 1;

Hi Mateusz,

The above part doesn’t apply on my current mdadm-CI queue. Just FYI, after I finish to review all this series, I will ask you to confirm the rebased patch or repost another version.

Thanks.

Coly Li



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux