On 8/25/22 03:59, Mariusz Tkaczyk wrote: > On Thu, 25 Aug 2022 10:24:21 +1000 > "NeilBrown" <neilb@xxxxxxx> wrote: >>> What is the consensus on this discussion? I see Coly pulled this into >>> his tree, but I don't see Mariusz's last concern being addressed. >> >> I don't think we reached a consensus. I probably got distracted. >> I don't like that suggestion from Mariusz as it makes assumptions that I >> didn't want to make. I think it is safest to always test dsize against >> bother ->size and ->data_size without baking in assumptions about when >> either is meaningful. No worries, distraction is my middle name these days :) > Hi Neil, > It seems that I failed to understand it again. You are right, you approach is > safer. Please fix stylistic issues then and I'm fine with the change. Thanks Mariusz Jes