Re: [PATCH v3] Grow: Split Grow_reshape into helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> 2022年8月24日 23:56,Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx> 写道:
> 
> On 8/8/22 06:03, Coly Li wrote:
>> 
>> 
>>> 2022年8月8日 04:41,Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx> 写道:
>>> 
>>> On 6/9/22 03:41, Mateusz Kusiak wrote:
>>>> Grow_reshape should be split into helper functions given its size.
>>>> - Add helper function for preparing reshape on external metadata.
>>>> - Close cfd file descriptor.
>>>> Signed-off-by: Mateusz Kusiak <mateusz.kusiak@xxxxxxxxx>
>>>> ---
>>>> Changes since v2:
>>>> - removed dot from commit message
>>>> - formatted commit description as a list
>>>> - got rid of returning -1 in prepare_external_reshape()
>>>> - changed "return" section in prepare_external_reshape() description
>>> 
>>> Hi Mateusz,
>>> 
>>> Changes look good to me, but it no longer applies. Mind sending an updated version?
>> 
>> Hi Jes,
>> 
>> Please check the version I post to you in series “mdadm-CI for-jes/20220728: patches for merge” (Message-Id: <20220728122101.28744-1-colyli@xxxxxxx>), the patch in this series is rebased and confirmed with Mateusz, it could be applied to upstream mdadm.
> 
> Hi
> 

> I applied this one, but none of the versions applied cleanly. I had to
> play formail games to pull it out of your stack, as I am not going to
> apply a set of 23 commits in one batch without going through them.
> 

These days I was in partner’s office and planed to repost the rebased version soon. If you don’t do the rebase yet, please wait for me to post a v4 version on behavior of Mateusz tomorrow.

> It's really awesome to have your help reviewing patches, much
> appreciated, but I would prefer to keep them in the original batches so
> I can pull them from patchwork, rather than trying to deal with the
> giant stack.

How about we improve the process like this,
1) I will continue to review and response the patches from the original emails, so patch work may track them as they were.
2) For all the reviewed patches are not handled by your after a period, let’s set it as 2 weeks for now, I will post a email with all the patches with their message-IDs to you as a remind.

Thanks.

Coly Li



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux