On Wed, Jul 27, 2022 at 03:06:00PM -0600, Logan Gunthorpe wrote: > +static struct stripe_head *__raid5_get_active_stripe(struct r5conf *conf, > + struct stripe_request_ctx *ctx, sector_t sector, > + bool previous, bool noblock, bool noquiesce) Passing three different bool arguments right after another is a really confusing calling convention, at some point this should become a set of flags. I'd also drop the __raid5_get_active_stripe vs raid5_get_active_stripe distinction.
