On 7/5/22 01:38, Christoph Hellwig wrote: > On Thu, Jun 30, 2022 at 02:14:00AM -0700, Chaitanya Kulkarni wrote: >> This adds support for the REQ_OP_VERIFY. In this version we add >> support for block layer. NVMe host side, NVMeOF Block device backend, >> and NVMeOF File device backend and null_blk driver. > > Who is "we" in this patch set? > >> Here is a link for the complete cover-letter for the background to save >> reviewer's time :- >> https://patchwork.kernel.org/project/dm-devel/cover/20211104064634.4481-1-chaitanyak@xxxxxxxxxx/ > > Well, the cover letter should be here. I'll send out with the updated cover-letter and fix the wording. > > Also I don't see how an NVMe-only implementation. If we don't also > cover SCSI and ATA there isn't much this API buys a potential user. I'll add to in the next version. My device went bad to test the scsi code, I think scsi_debug should be okay for testing until I have the scsi controller. -ck
