> 2022年6月9日 15:41，Mateusz Kusiak <mateusz.kusiak@xxxxxxxxx> 写道： > > Grow_reshape should be split into helper functions given its size. > - Add helper function for preparing reshape on external metadata. > - Close cfd file descriptor. > > Signed-off-by: Mateusz Kusiak <mateusz.kusiak@xxxxxxxxx> Hi Mateusz, Overall I am fine with this patch. Currently it dose apply on branch 20220621-testing of the mdadm-CI tree. This branch is based on mdadm upstream commit 756a15f32338 (“imsm: Remove possibility for get_imsm_dev to return NULL”) and stacked with other asked patch from for-jes/20220620. I will response this patch after other queuing patches are handled by Jes. If the change is minor, I will do the patch rebase and inform you. Thanks. Coly Li > --- > > Changes since v2: > - removed dot from commit message > - formatted commit description as a list > - got rid of returning -1 in prepare_external_reshape() > - changed "return" section in prepare_external_reshape() description > > --- > Grow.c | 124 ++++++++++++++++++++++++++++++-------------------------- > mdadm.h | 1 + > util.c | 14 +++++++ > 3 files changed, 81 insertions(+), 58 deletions(-) > [snipped]
