Re: [PATCH 2/2] md: unlock mddev before reap sync_thread in action_store

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 6/8/22 6:59 AM, Song Liu wrote:
On Tue, Jun 7, 2022 at 2:46 AM Guoqing Jiang <guoqing.jiang@xxxxxxxxx> wrote:
Pls hold on, I will verify it with latest kernel.

Thanks,
Guoqing

On 6/7/22 10:03 AM, Guoqing Jiang wrote:
Since the bug which commit 8b48ec23cc51a ("md: don't unregister sync_thread
with reconfig_mutex held") fixed is related with action_store path, other
callers which reap sync_thread didn't need to be changed.

Let's pull md_unregister_thread from md_reap_sync_thread, then fix previous
bug with belows.

1. unlock mddev before md_reap_sync_thread in action_store.
2. save reshape_position before unlock, then restore it to ensure position
     not changed accidentally by others.

Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
This version doesn't really work. Maybe we should ship the revert first?

Agree, pls apply the revert first.

Thanks,
Guoqing



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux