On Wed, Jun 1, 2022 at 3:42 PM Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote: > > > > On 2022-06-01 16:36, Song Liu wrote: > >> I guess we could do that. All the inline functions in raid5-log.h are > >> there to choose between the r5l or the ppl implementaiton. So it that > >> would mean the r5l implementation would probably be inlined and ppl > >> would be doing a second out of line call. Not sure if that matters, but > >> it seems a little odd. > > > > I like the current version better. raid5-log.h is not used in many files anyway. > > It's a moot point now. v3 will follow Christoph's other feedback which > essentially removes the RCU access altogether and adds an appropriate > lock in a couple places. Ah, that's right. Thanks for pointing it out. Song
