> 2022年4月7日 22:27，Lukasz Florczak <lukasz.florczak@xxxxxxxxxxxxxxx> 写道：
>
> imsm_create_metadata_update_for_size_change() that returns u_size value
> could return 0 in the past. As its behavior changed, and returned value
> is always the size of imsm_update_size_change structure, check for
> u_size is no longer needed.
>
> Signed-off-by: Lukasz Florczak <lukasz.florczak@xxxxxxxxxxxxxxx>
It looks good to me.
Acked-by: Coly Li <colyli@xxxxxxx>
Thanks.
Coly Li
> ---
> super-intel.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 102689bc..cb5292e1 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -11772,10 +11772,6 @@ static int imsm_fix_size_mismatch(struct supertype *st, int subarray_index)
> geo.size = d_size;
> u_size = imsm_create_metadata_update_for_size_change(st, &geo,
> &update);
> - if (u_size < 1) {
> - dprintf("imsm: Cannot prepare size change update\n");
> - goto exit;
> - }
> imsm_update_metadata_locally(st, update, u_size);
> if (st->update_tail) {
> append_metadata_update(st, update, u_size);
> --
> 2.27.0
>
