Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Song Liu <song@xxxxxxxxxx>, Donald Buczek <buczek@xxxxxxxxxxxxx>
Subject: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses
From: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Date: Tue, 24 May 2022 10:14:03 -0600
Cc: open list <linux-kernel@xxxxxxxxxxxxxxx>, linux-raid <linux-raid@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Guoqing Jiang <guoqing.jiang@xxxxxxxxx>, Xiao Ni <xni@xxxxxxxxxx>, Stephen Bates <sbates@xxxxxxxxxxxx>, Martin Oliveira <Martin.Oliveira@xxxxxxxxxxxxx>, David Sloan <David.Sloan@xxxxxxxxxxxxx>
In-reply-to: <CAPhsuW5DUT6gg4eP7ozAwWdEiqen1eZwWeYAM5Jo7yY0h+LGcQ@mail.gmail.com>
References: <20220519191311.17119-1-logang@deltatee.com> <20220519191311.17119-13-logang@deltatee.com> <62b09487-9223-db3d-2165-789a51230060@molgen.mpg.de> <CAPhsuW5FKh7VKgU+=eU4_ad4btFMwU7ymMNMZ5TZVQbv82MaHg@mail.gmail.com> <CAPhsuW5DUT6gg4eP7ozAwWdEiqen1eZwWeYAM5Jo7yY0h+LGcQ@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0


On 2022-05-23 12:15, Song Liu wrote:
> On Sun, May 22, 2022 at 11:47 PM Song Liu <song@xxxxxxxxxx> wrote:
>> Maybe we should move the definition of r5l_log to raid5-log.h?
> 
> Or we can use READ_ONCE(conf->log) for most cases.

READ_ONCE() will still generate sparse errors.

Logan

References:
- [PATCH v1 00/15] Bug fixes for mdadm tests
  - From: Logan Gunthorpe
- [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses
  - From: Logan Gunthorpe
- Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses
  - From: Donald Buczek
- Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses
  - From: Song Liu
- Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses
  - From: Song Liu

Prev by Date: Re: [Update PATCH V3] md: don't unregister sync_thread with reconfig_mutex held
Next by Date: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses
Previous by thread: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses
Next by thread: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]