Re: [Update PATCH V3] md: don't unregister sync_thread with reconfig_mutex held

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 10, 2022 at 5:35 AM Donald Buczek <buczek@xxxxxxxxxxxxx> wrote:
>
> On 5/10/22 2:09 PM, Guoqing Jiang wrote:
> >
> >
> > On 5/10/22 8:01 PM, Donald Buczek wrote:
> >>
> >>> I guess v2 is the best at the moment. I pushed a slightly modified v2 to
> >>> md-next.
> >>
> >> I think, this can be used to get a double-free from md_unregister_thread.
> >>
> >> Please review
> >>
> >> https://lore.kernel.org/linux-raid/8312a154-14fb-6f07-0cf1-8c970187cc49@xxxxxxxxxxxxx/
> >
> > That is supposed to be addressed by the second one, pls consider it too.
>
> Right, but this has not been pulled into md-next. I just wanted to note, that the current state of md-next has this problem.
>
> If the other patch is taken, too, and works as intended, that would be solved.
>
> > [PATCH 2/2] md: protect md_unregister_thread from reentrancy

Good catch!

Guoqing, current 2/2 doesn't apply cleanly. Could you please resend it on top of
md-next?

Thanks,
Song



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux