On 4/21/22 3:54 AM, Logan Gunthorpe wrote:
Both uses of find_stripe() require a fairly complicated dance to
increment the reference count. Move this into a common find_get_stripe()
helper.
No functional changes intended.
Signed-off-by: Logan Gunthorpe<logang@xxxxxxxxxxxx>
---
drivers/md/raid5.c | 133 ++++++++++++++++++++++-----------------------
1 file changed, 65 insertions(+), 68 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 8e1ece5ce984..a0946af5b1ac 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -612,7 +612,7 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int previous)
}
...
@@ -624,6 +624,49 @@ static struct stripe_head *__find_stripe(struct r5conf *conf, sector_t sector,
return NULL;
}
+static struct stripe_head *find_get_stripe(struct r5conf *conf,
+ sector_t sector, short generation, int hash)
+{
The subject doesn't match the change, maybe something about " md/raid5:
factor out common stripe count
increment code into find_get_stripe()", just FYI. Otherwise, it
generally looks good.
Acked-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
Thanks,
Guoqing
