On 21/04/2022 17:05, Logan Gunthorpe wrote:
I like the ternary too, but is there a superfluous return in there? That would shorten the line. Or break it on the question mark - condition, true, false all on their own lines.I like the ternary operator.;-) return mddev->reshape_backwards ? (return sector < reshape_sector) : (sector >= reshape_sector) Sorry, does not matter.Yeah, I think plenty of people do not, though; it's harder to read with the long line and awkward to wrap.
Cheers, Wol