On Wed, Apr 20, 2022 at 01:54:24PM -0600, Logan Gunthorpe wrote: > +static bool range_ahead_of_reshape(struct mddev *mddev, sector_t min, > + sector_t max, sector_t reshape_sector) > +{ > + if (mddev->reshape_backwards) > + return max < reshape_sector; > + else > + return min >= reshape_sector; > +} Nit: no need for the return. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>