On Wed, Apr 20, 2022 at 01:54:14PM -0600, Logan Gunthorpe wrote: > +static bool ahead_of_reshape(struct mddev *mddev, sector_t sector, > + sector_t reshape_sector) > +{ > + if (mddev->reshape_backwards) > + return sector < reshape_sector; > + else > + return sector >= reshape_sector; > +} No real eed for the else here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>