Re: [PATCH v1 2/8] md/raid5: Move stripe_add_to_batch_list() call out of add_stripe_bio()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Subject: Re: [PATCH v1 2/8] md/raid5: Move stripe_add_to_batch_list() call out of add_stripe_bio()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 7 Apr 2022 23:00:16 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, Song Liu <song@xxxxxxxxxx>, Shaohua Li <shli@xxxxxxxxxx>, Guoqing Jiang <guoqing.jiang@xxxxxxxxx>, Stephen Bates <sbates@xxxxxxxxxxxx>, Martin Oliveira <Martin.Oliveira@xxxxxxxxxxxxx>, David Sloan <David.Sloan@xxxxxxxxxxxxx>
In-reply-to: <20220407164511.8472-3-logang@deltatee.com>
References: <20220407164511.8472-1-logang@deltatee.com> <20220407164511.8472-3-logang@deltatee.com>

On Thu, Apr 07, 2022 at 10:45:05AM -0600, Logan Gunthorpe wrote:
> The call to add_stripe_bio() in retry_aligned_read() is for a read only
> and thus wouldn't have added the batch anyway.

This sentence is missing an object.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v1 0/8] Improve Raid5 Lock Contention
  - From: Logan Gunthorpe
- [PATCH v1 2/8] md/raid5: Move stripe_add_to_batch_list() call out of add_stripe_bio()
  - From: Logan Gunthorpe

Prev by Date: Re: [PATCH] md: fix an incorrect NULL check in md_reload_sb
Next by Date: Re: [PATCH v1 1/8] md/raid5: Refactor raid5_make_request loop
Previous by thread: [PATCH v1 2/8] md/raid5: Move stripe_add_to_batch_list() call out of add_stripe_bio()
Next by thread: [PATCH v1 7/8] md/raid5: Check all disks in a stripe_head for reshape progress
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]

Powered by Linux