Hi Jes Could you merge this patch. On Tue, Feb 15, 2022 at 9:34 PM Coly Li <colyli@xxxxxxx> wrote: > > For mdadm's systemd configuration, current systemd KillMode is "none" in > following service files, > - mdadm-grow-continue@.service > - mdmon@.service > > This "none" mode is strongly againsted by systemd developers (see man 5 > systemd.kill for "KillMode=" section), and is considering to remove in > future systemd version. > > As systemd developer explained in disuccsion, the systemd kill process > is, > 1. send the signal specified by KillSignal= to the list of processes (if > any), TERM is the default > 2. wait until either the target of process(es) exit or a timeout expires > 3. if the timeout expires send the signal specified by FinalKillSignal=, > KILL is the default > > For "control-group", all remaining processes will receive the SIGTERM > signal (by default) and if there are still processes after a period f > time, they will get the SIGKILL signal. > > For "mixed", only the main process will receive the SIGTERM signal, and > if there are still processes after a period of time, all remaining > processes (including the main one) will receive the SIGKILL signal. > > From the above comment, currently KillMode=control-group is a proper > kill mode. Since control-gropu is the default kill mode, the fix can be > simply removing KillMode=none line from the service file, then the > default mode will take effect. > > Signed-off-by: Coly Li <colyli@xxxxxxx> > Cc: Benjamin Brunner <bbrunner@xxxxxxxx> > Cc: Franck Bui <fbui@xxxxxxx> > Cc: Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx> > Cc: Mariusz Tkaczyk <mariusz.tkaczyk@xxxxxxxxxxxxxxx> > Cc: Neil Brown <neilb@xxxxxxx> > Cc: Xiao Ni <xni@xxxxxxxxxx> > --- > systemd/mdadm-grow-continue@.service | 1 - > systemd/mdmon@.service | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/systemd/mdadm-grow-continue@.service b/systemd/mdadm-grow-continue@.service > index 5c667d2..9fdc8ec 100644 > --- a/systemd/mdadm-grow-continue@.service > +++ b/systemd/mdadm-grow-continue@.service > @@ -14,4 +14,3 @@ ExecStart=BINDIR/mdadm --grow --continue /dev/%I > StandardInput=null > StandardOutput=null > StandardError=null > -KillMode=none > diff --git a/systemd/mdmon@.service b/systemd/mdmon@.service > index 85a3a7c..7753395 100644 > --- a/systemd/mdmon@.service > +++ b/systemd/mdmon@.service > @@ -25,4 +25,3 @@ Type=forking > # it out) and systemd will remove it when transitioning from > # initramfs to rootfs. > #PIDFile=/run/mdadm/%I.pid > -KillMode=none > -- > 2.31.1 > Acked-by: Xiao Ni <xni@xxxxxxxxxx>
